Skip to content

NETOBSERV-2617 help improvments#492

Open
jpinsonneau wants to merge 2 commits intonetobserv:mainfrom
jpinsonneau:2617
Open

NETOBSERV-2617 help improvments#492
jpinsonneau wants to merge 2 commits intonetobserv:mainfrom
jpinsonneau:2617

Conversation

@jpinsonneau
Copy link
Copy Markdown
Member

@jpinsonneau jpinsonneau commented Mar 25, 2026

Description

commands/netobserv

  • Fixed --help detection to work at any argument position (replaced nested case "$2" with contains_help function)
  • Fixed regex grouping for help/version skip and yaml detection
  • Added "" pattern to show help when no arguments are provided
  • Added keyword highlighting when --help is used with other flags

scripts/functions.sh

  • Added missing --interfaces command guard for packets (matching --exclude_interfaces)

scripts/help.sh

  • Added get_help_keywords and highlight_keywords utilities for contextual help highlighting
  • Added --help discoverability hint in main help
  • Fixed typos: "asyncronously", "allows you stop", "allows you copy"

Assisted-by: claude-4.6-opus-high

Dependencies

n/a

Checklist

  • Does the changes in PR need specific configuration or environment set up for testing?
    • if so please describe it in PR description.
  • I have added thorough unit tests for the change.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Amoghrd
Copy link
Copy Markdown
Member

Amoghrd commented Mar 26, 2026

/ok-to-test

@Amoghrd Amoghrd added the needs-review Tells that the PR needs a review label Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.18%. Comparing base (936cdf7) to head (29f5070).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   13.18%   13.18%           
=======================================
  Files          20       20           
  Lines        2443     2443           
=======================================
  Hits          322      322           
  Misses       2095     2095           
  Partials       26       26
Flag Coverage Δ
unittests 13.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroberetta leandroberetta Awaiting requested review from leandroberetta

@jotak jotak Awaiting requested review from jotak

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-review Tells that the PR needs a review ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpinsonneau @Amoghrd